Skip to content

DOCS-3120 APM docs restructure #14417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jul 11, 2022
Merged

DOCS-3120 APM docs restructure #14417

merged 44 commits into from
Jul 11, 2022

Conversation

kayayarai
Copy link
Collaborator

@kayayarai kayayarai commented Jun 24, 2022 •
edited
Loading

What does this PR do?

Restructures APM docs

Motivation

PM discussion

Preview

https://docs-staging.datadoghq.com/kari/docs-3120b-apm-restructure/tracing/

@kayayarai kayayarai added the Do Not Merge Just do not merge this PR :) label Jun 24, 2022
@kayayarai kayayarai requested review from a team as code owners June 24, 2022 15:22
@kayayarai kayayarai removed the request for review from a team July 8, 2022 21:24
@kayayarai kayayarai added editorial review Waiting on a more in-depth review and removed monitors Content changed in the monitors folder integrations Content changed in the integrations folder getting_started Content changed in the getting started folder synthetics Content changed in the synthetics folder serverless database_monitoring containers Do Not Merge Just do not merge this PR :) labels Jul 8, 2022
@apigirl
Copy link
Contributor

apigirl commented Jul 11, 2022 •
edited
Loading

Review checklist

  • double check single sourcing ruby, ios, android
  • name change + alias for moved pages
  • edit 6 pages from spreadsheet:
    • tracing/
    • tracing/trace_collection/
    • tracing/metrics/
    • tracing/trace_pipeline/
    • tracing/other_telemetry/
    • tracing/services/
  • double check normal nav functionality
  • double check that it's only changes to tracing content (one new image)

@apigirl
Copy link
Contributor

apigirl commented Jul 11, 2022 •
edited
Loading

https://docs-staging.datadoghq.com/kari/docs-3120b-apm-restructure/tracing/trace_collection/custom_instrumentation/ known issue with clicking on these, non blocking, we'll fix this separately

@apigirl
Copy link
Contributor

apigirl commented Jul 11, 2022

are https://docs-staging.datadoghq.com/kari/docs-3120b-apm-restructure/tracing/trace_collection/dd_libraries/android/?tabs=kotlin and https://docs-staging.datadoghq.com/kari/docs-3120b-apm-restructure/tracing/trace_collection/dd_libraries/ios/?tabs=cocoapods supposed to not be in the nav anywhere?

apigirl
apigirl reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits mostly to content that you didn't write

@apigirl
Copy link
Contributor

apigirl commented Jul 11, 2022

are https://docs-staging.datadoghq.com/kari/docs-3120b-apm-restructure/tracing/trace_collection/dd_libraries/android/?tabs=kotlin and https://docs-staging.datadoghq.com/kari/docs-3120b-apm-restructure/tracing/trace_collection/dd_libraries/ios/?tabs=cocoapods supposed to not be in the nav anywhere?

looks like this is not supposed to be in the nav

kayayarai
kayayarai commented Jul 11, 2022
View reviewed changes
kayayarai and others added 2 commits July 11, 2022 11:51
@kayayarai
fix nav bug
0c3fc9b
@kayayarai
Apply suggestions from code review
d050d1a 
Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com>
@apigirl apigirl removed the editorial review Waiting on a more in-depth review label Jul 11, 2022
@kayayarai kayayarai merged commit 85c7bdc into master Jul 11, 2022
@kayayarai kayayarai deleted the kari/docs-3120b-apm-restructure branch July 11, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@apigirl apigirl apigirl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Guide Content impacting a guide Images Images are added/removed with this PR infrastructure Content changed in the infrastructure folder tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayayarai @apigirl