Skip to content

OTLP CONFIG vars take full endpoints not ports #14949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2022
Merged

OTLP CONFIG vars take full endpoints not ports #14949

merged 4 commits into from
Sep 23, 2022

Conversation

ajgajg1134
Copy link
Contributor

Tested with the latest release candidate of the agent, note this brings this tab into alignment with the host tab

What does this PR do?

Motivation

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@ajgajg1134
OTLP CONFIG vars take full endpoints not ports
49fc461 
Tested with the latest release candidate of the agent, note this brings this tab into alignment with the `host` tab
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

gbbr
gbbr approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Your change is correct!

@gbbr gbbr marked this pull request as ready for review August 10, 2022 14:09
@gbbr gbbr requested a review from a team as a code owner August 10, 2022 14:09
@gbbr gbbr requested a review from mx-psi August 10, 2022 14:09
mx-psi
mx-psi reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what the sentence was meant to say is that you need to pass the environment variable (with the full endpoint) and also expose the port. I left a suggestion to make the wording clearer

@ajgajg1134 @mx-psi
Update content/en/tracing/trace_collection/open_standards/otlp_ingest…
5346b72 
…_in_the_agent.md

Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
buraizu
buraizu requested changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a minor edit for consistency.

@ajgajg1134 @buraizu
Update content/en/tracing/trace_collection/open_standards/otlp_ingest…
b8d9c6e 
…_in_the_agent.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@ajgajg1134 ajgajg1134 requested a review from buraizu August 11, 2022 20:27
@kayayarai kayayarai merged commit a30847b into master Sep 23, 2022
@kayayarai kayayarai deleted the andrew.glaude/OTLPConfig branch September 23, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@buraizu buraizu buraizu approved these changes

+1 more reviewer

@gbbr gbbr gbbr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajgajg1134 @mx-psi @gbbr @buraizu @kayayarai