Skip to content

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Aug 11, 2022

Some corrections as agreed upon:

  • "Alongside the Datadog Agent" moved out of "Using Kubernetes" section
  • Removed confusing parenthesis mentioning collector.yaml
  • Switched "Kubernetes Infrastructure Metrics" wording to "Kubernetes attributes"

Some corrections as agreed upon:
- [x] "Alongside the Datadog Agent" moved out of "Using Kubernetes" section
- [x] Removed confusing parenthesis mentioning `collector.yaml`
- [x] Switched "Kubernetes Infrastructure Metrics" wording to "Kubernetes attributes"
@gbbr gbbr requested a review from a team as a code owner August 11, 2022 09:17
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Aug 11, 2022
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@pj-datadog pj-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment on line 247, let's address that. Everything else looks good for now.

@gbbr gbbr requested a review from hestonhoffman August 18, 2022 14:26
@hestonhoffman hestonhoffman merged commit eeda63f into master Aug 24, 2022
@hestonhoffman hestonhoffman deleted the gbbr/otel-corrections branch August 24, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracing Content changed in the tracing folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants