Skip to content

Update Service check monitor #15950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2022
Merged

Update Service check monitor #15950

merged 4 commits into from
Nov 21, 2022

Conversation

estherk15
Copy link
Contributor

What does this PR do?

Update the Service Check Monitor page

  • Removed the WARN option for triggering alerts since it's not available as an option
  • Added the Service Check overview as another resource
  • Shifted information around for Cluster Alerts

Motivation

DOCS-4395

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@estherk15 estherk15 requested a review from a team as a code owner November 16, 2022 19:15
@github-actions github-actions bot added the monitors Content changed in the monitors folder label Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@estherk15 estherk15 added the Do Not Merge Just do not merge this PR :) label Nov 16, 2022
@estherk15 estherk15 force-pushed the esther/docs-4395/service-check-update branch from 88307b8 to 5a812d9 Compare November 16, 2022 20:29
@estherk15 estherk15 removed the Do Not Merge Just do not merge this PR :) label Nov 16, 2022
alai97
alai97 suggested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some copy suggestions!

@estherk15 estherk15 requested a review from a team as a code owner November 17, 2022 01:45
@github-actions github-actions bot added account_management Content changed in the Account_management folder agent Content changed in the Agent folder dashboards Content changed in the dashboards folder getting_started Content changed in the getting started folder Guide Content impacting a guide metrics Content changed in the metrics folder profiler real_user_monitoring Content changed in the real_user_monitoring folder security_platform serverless tracing Content changed in the tracing folder labels Nov 17, 2022
@estherk15 estherk15 removed monitors Content changed in the monitors folder agent Content changed in the Agent folder tracing Content changed in the tracing folder account_management Content changed in the Account_management folder real_user_monitoring Content changed in the real_user_monitoring folder getting_started Content changed in the getting started folder metrics Content changed in the metrics folder Guide Content impacting a guide serverless labels Nov 17, 2022
@estherk15 estherk15 force-pushed the esther/docs-4395/service-check-update branch from 1d3de4b to 3bb322d Compare November 17, 2022 02:09
@github-actions github-actions bot added the monitors Content changed in the monitors folder label Nov 17, 2022
@estherk15 estherk15 removed the request for review from a team November 17, 2022 02:09
@estherk15 @alai97
Apply suggestions from code review
d4931bf 
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@estherk15 estherk15 requested a review from alai97 November 18, 2022 14:39
@estherk15 estherk15 merged commit a323395 into master Nov 21, 2022
@estherk15 estherk15 deleted the esther/docs-4395/service-check-update branch November 21, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alai97 alai97 alai97 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dashboards Content changed in the dashboards folder monitors Content changed in the monitors folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estherk15 @alai97