Skip to content

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Mar 29, 2023

new version of #17345

@cswatt cswatt requested a review from a team as a code owner March 29, 2023 18:33
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@cswatt cswatt mentioned this pull request Mar 29, 2023
4 tasks
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback, but otherwise looks good!

### Logs are not collected

There are two [environment variables][8] that can impact if logs will be collected and from which containers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean the environment variables can...

have an impact? be impacted? impact something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call gonna replace it with "affect"

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cswatt cswatt merged commit beab82e into master Mar 29, 2023
@cswatt cswatt deleted the cswatt/containers-troubleshooting branch March 29, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants