Skip to content

[K8s Operator] Moves credentials to global per v2alpha1 spec #17816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

[K8s Operator] Moves credentials to global per v2alpha1 spec #17816

merged 1 commit into from
Apr 21, 2023

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Apr 21, 2023 •
edited
Loading

What does this PR do?

  • Moves spec.credentials to spec.global.credentials per v2alpha1 spec

Motivation

  • Self-testing, noticed the doc is incorrect and leads to the error :
Error from server (BadRequest): error when creating "op.yaml": DatadogAgent in version "v2alpha1" cannot be handled as a DatadogAgent: strict decoding error: unknown field "spec.credentials"

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@tbavelier tbavelier requested a review from a team April 21, 2023 10:06
@tbavelier tbavelier requested a review from a team as a code owner April 21, 2023 10:06
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@estherk15 estherk15 merged commit 30a9eba into master Apr 21, 2023
@estherk15 estherk15 deleted the tbavelier/fix_operator_intro_creds branch April 21, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

+1 more reviewer

@CharlyF CharlyF CharlyF approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbavelier @CharlyF @estherk15