Skip to content

New Version History guides for Dashboards and Notebooks #18207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2023
Merged

New Version History guides for Dashboards and Notebooks #18207

merged 6 commits into from
May 22, 2023

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented May 19, 2023 •
edited
Loading

What does this PR do?

  • Add high level overview of Version History in Dashboard and Notebooks pages
  • New Version History guides for both Notebooks and Dashboards

Motivation

DOCS-5449

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@estherk15 estherk15 requested a review from a team as a code owner May 19, 2023 18:30
@github-actions github-actions bot added Guide Content impacting a guide Images Images are added/removed with this PR labels May 19, 2023
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label May 19, 2023
alai97
alai97 reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some copy suggestions!

@estherk15 @alai97
Apply suggestions from code review
9e35c67 
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@estherk15 estherk15 requested a review from alai97 May 22, 2023 13:34
@estherk15
Copy link
Contributor Author

Thanks for the review @alai97, took all your suggestions except for one since it's still under a feature flag 🙇‍♀️

alai97
alai97 approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@estherk15 estherk15 merged commit 331cedc into master May 22, 2023
@estherk15 estherk15 deleted the esther/docs-5449-version-history branch May 22, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alai97 alai97 alai97 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estherk15 @alai97