Skip to content

Bryce/gcp logs guide #19467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 16, 2023
Merged

Bryce/gcp logs guide #19467

merged 28 commits into from
Oct 16, 2023

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented Aug 22, 2023 •
edited
Loading

What does this PR do?

Add a Google Cloud logging guide

Motivation

DOCS-6018

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@buraizu buraizu added the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 22, 2023
@buraizu buraizu requested a review from a team as a code owner August 22, 2023 20:53
@github-actions github-actions bot added the Guide Content impacting a guide label Aug 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

sriramkraman
sriramkraman reviewed Aug 30, 2023
View reviewed changes
Copy link

@sriramkraman sriramkraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buraizu thanks for your patience on this review. I took a pass. Please let me know if you'd like to discuss this more.

@buraizu
Copy link
Contributor Author

buraizu commented Sep 1, 2023

@sriramkraman thank you for taking the time to review. I've incorporated your feedback and posted a follow-up question. Thanks in advance for any additional feedback!

@buraizu buraizu requested a review from sriramkraman September 1, 2023 23:00
@sriramkraman
Copy link

@buraizu can we also consider adding a deprecation warning (without a specific date mentioned) on the pub/sub fowarding method?

@sriramkraman
Copy link

@buraizu do you have a preview of this page in staging - https://docs.datadoghq.com/integrations/google_cloud_platform?

@buraizu
Copy link
Contributor Author

buraizu commented Sep 14, 2023

Hi @sriramkraman just following up to let you know I've made a round of edits on this update incorporating the structure you confirmed here.
I've already shared the preview and PR for the associated updates to the main Google Cloud doc in dogweb with you through Slack.
Thanks again for taking a look, and thanks in advance for any additional feedback!

sriramkraman
sriramkraman reviewed Sep 19, 2023
View reviewed changes
sriramkraman
sriramkraman reviewed Sep 19, 2023
View reviewed changes
sriramkraman
sriramkraman reviewed Sep 19, 2023
View reviewed changes
Copy link

@sriramkraman sriramkraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buraizu added some comments here. I'd recommend calling this method deprecated and informing customers they have to move over to using Dataflow to avail batching and compression benefits.

@sriramkraman sriramkraman requested a review from LucasC September 19, 2023 19:56
sriramkraman
sriramkraman reviewed Sep 27, 2023
View reviewed changes
sriramkraman
sriramkraman reviewed Sep 27, 2023
View reviewed changes
Copy link

@sriramkraman sriramkraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One title update requested. LGTM otherwise.

LucasC
LucasC approved these changes Sep 29, 2023
View reviewed changes
sriramkraman
sriramkraman approved these changes Oct 2, 2023
View reviewed changes
Copy link

@sriramkraman sriramkraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buraizu buraizu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 3, 2023
@maycmlee
Copy link
Contributor

maycmlee commented Oct 3, 2023 •
edited by jira bot
Loading

Created DOCS-6339 for docs review.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review label Oct 3, 2023
ash-ddog
ash-ddog reviewed Oct 5, 2023
View reviewed changes
Copy link

@ash-ddog ash-ddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want some of the changes I suggested, but overall looks good. Thank you! 🙏

@github-actions github-actions bot added the Images Images are added/removed with this PR label Oct 5, 2023
@buraizu buraizu requested a review from ash-ddog October 5, 2023 19:50
ash-ddog
ash-ddog approved these changes Oct 5, 2023
View reviewed changes
Copy link

@ash-ddog ash-ddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback! LGTM

maycmlee
maycmlee reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small edits!

maycmlee
maycmlee reviewed Oct 6, 2023
View reviewed changes
@buraizu buraizu requested a review from maycmlee October 6, 2023 21:42
@buraizu buraizu removed the request for review from pgkamat October 12, 2023 23:00
@buraizu buraizu merged commit fe97f2b into master Oct 16, 2023
@buraizu buraizu deleted the bryce/gcp-logs-guide branch October 16, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramkraman sriramkraman sriramkraman approved these changes

@maycmlee maycmlee maycmlee approved these changes

@ash-ddog ash-ddog ash-ddog approved these changes

+1 more reviewer

@LucasC LucasC LucasC approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@buraizu @sriramkraman @LucasC @maycmlee @ash-ddog