Skip to content

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Oct 13, 2023

What does this PR do? What is the motivation?

Updates CoScreen docs in accordance with capabilities.

  • you can sign in with your Datadog account
  • background blurring on macOS
  • noise suppression

Also added info from a coscreen support article, Why does the audio quality degrade... to the troubleshooting page.

Merge instructions

  • Please merge after reviewing

Additional notes

@cswatt cswatt requested a review from a team as a code owner October 13, 2023 21:15
@github-actions
Copy link
Contributor

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Offered a suggestion to squish one of the longer sentences down to 25 words.


If you're using a Bluetooth headset, the playback quality may degrade when your headset's microphone is selected as an audio input device. You may notice this if you play audio (for example, play a YouTube video) while you are in a CoScreen session. This can occur because your Bluetooth headset has switched to using a different Bluetooth profile.

When only playing audio, Bluetooth headsets typically use the [A2DP profile][2], which is optimized for high audio quality but does not support using the microphone. If you choose your headset microphone as audio input (for example, during a CoScreen session or Zoom meeting) the headset switches to a different profile, usually [HFP][3] or [HSP][4], which supports microphone usage but has lower sound quality. Most Bluetooth headsets can use only one profile at a time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When only playing audio, Bluetooth headsets typically use the [A2DP profile][2], which is optimized for high audio quality but does not support using the microphone. If you choose your headset microphone as audio input (for example, during a CoScreen session or Zoom meeting) the headset switches to a different profile, usually [HFP][3] or [HSP][4], which supports microphone usage but has lower sound quality. Most Bluetooth headsets can use only one profile at a time.
When only playing audio, Bluetooth headsets typically use the [A2DP profile][2], which is optimized for high quality audio but does not support using the microphone. When selecting your headset microphone as input, (for example, in CoScreen or Zoom), it switches to the [HFP][3] or [HSP][4] profile with lower audio quality. Most Bluetooth headsets can use only one profile at a time.

My attempt at appeasing the linter and making this sentence 25 words.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm. i'd like to keep this sentence below 25 words, but i'm not willing to sacrifice antecedent clarity, so the linter's gonna have to stay mad

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@cswatt cswatt merged commit 92feb8f into master Oct 16, 2023
@cswatt cswatt deleted the cswatt/coscreen_2310_updates branch October 16, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants