-
Notifications
You must be signed in to change notification settings - Fork 1.2k
opentelemetry(apm): document python and ruby drop in support #24257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
f1f4b1b
to
b478764
Compare
bb9cc53
to
4f51496
Compare
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
3bdb97e
to
8c9aa08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you change "Using operations only supported by
OpenTelemetry SDK are not supported (ex: SpanProcessors, OTLP Trace Exporters)."
to something like,
"Items specific to the Opentelemetry SDK (ex: SpanProcessors, OTLP Trace Exporters) are not supported."
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates! 🙏 I left a few suggestions for you to consider. Please let me know if my comment on the Prerequisites section is unclear. I was unable to suggest changes since my comment spanned several lines that weren't changed.
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
20ff55b
to
e1a0471
Compare
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
content/en/opentelemetry/interoperability/instrumentation_libraries.md
Outdated
Show resolved
Hide resolved
Preview links (active after the
|
8c582c7
to
4000bcd
Compare
fix name ACCESSINT-23 Mark team and user based access supported for with GRACE for synthetic tests (#24298) DOCS-8523 Add Multisource Querying Documentation (#24312) * Move Data Collected * DOCS-8523 Adds a child doc page for Multisource Querying and accompanying screenshots. * Add Table Legend * Word Nit * This Too * Formatting Nit * Doc Review Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com> * One More --------- Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com> [CLOUDCRAFT-849] Update "Enable SSO" document (#24284) * Add information about Datadog SSO Signed-off-by: James Pond <james.pond@datadoghq.com> * Remove Enterprise requirement for SAML SSO Signed-off-by: James Pond <james.pond@datadoghq.com> * Clarify that support can enable the feature Signed-off-by: James Pond <james.pond@datadoghq.com> * Match the style guide more closely Signed-off-by: James Pond <james.pond@datadoghq.com> * Update image description Signed-off-by: James Pond <james.pond@datadoghq.com> * Update Enterprise notice on all documents Signed-off-by: James Pond <james.pond@datadoghq.com> * Apply suggestions made by @maycmlee Signed-off-by: James Pond <james.pond@datadoghq.com> * Apply one more suggestion by @maycmlee Signed-off-by: James Pond <james.pond@datadoghq.com> --------- Signed-off-by: James Pond <james.pond@datadoghq.com> DOCS-8258 Pipeline Execution Time Update (#24007) * DOCS-8258 Add a screenshot of a pipeline trace for the pipeline execution time terminology. * Add Diagram Update content/en/opentelemetry/interoperability/instrumentation_libraries.md Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com> fix typos Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com> clean up Apply suggestions from code review Apply suggestions from code review Apply suggestions from code review Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com> Apply suggestions from code review Apply suggestions from code review
4000bcd
to
a26cb13
Compare
a26cb13
to
328faaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚀
@mabdinur - Are we good to go ahead and merge this now? Thanks! |
* opentelemetry(apm): document python drop in support * document python and ruby support * more clean ups * --amend fix name ACCESSINT-23 Mark team and user based access supported for with GRACE for synthetic tests (#24298) DOCS-8523 Add Multisource Querying Documentation (#24312) * Move Data Collected * DOCS-8523 Adds a child doc page for Multisource Querying and accompanying screenshots. * Add Table Legend * Word Nit * This Too * Formatting Nit * Doc Review Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com> * One More --------- Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com> [CLOUDCRAFT-849] Update "Enable SSO" document (#24284) * Add information about Datadog SSO Signed-off-by: James Pond <james.pond@datadoghq.com> * Remove Enterprise requirement for SAML SSO Signed-off-by: James Pond <james.pond@datadoghq.com> * Clarify that support can enable the feature Signed-off-by: James Pond <james.pond@datadoghq.com> * Match the style guide more closely Signed-off-by: James Pond <james.pond@datadoghq.com> * Update image description Signed-off-by: James Pond <james.pond@datadoghq.com> * Update Enterprise notice on all documents Signed-off-by: James Pond <james.pond@datadoghq.com> * Apply suggestions made by @maycmlee Signed-off-by: James Pond <james.pond@datadoghq.com> * Apply one more suggestion by @maycmlee Signed-off-by: James Pond <james.pond@datadoghq.com> --------- Signed-off-by: James Pond <james.pond@datadoghq.com> DOCS-8258 Pipeline Execution Time Update (#24007) * DOCS-8258 Add a screenshot of a pipeline trace for the pipeline execution time terminology. * Add Diagram Update content/en/opentelemetry/interoperability/instrumentation_libraries.md Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com> fix typos Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com> clean up Apply suggestions from code review Apply suggestions from code review Apply suggestions from code review Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com> Apply suggestions from code review Apply suggestions from code review * Apply suggestions from code review
What does this PR do? What is the motivation?
Document Python and Ruby drop in support for the OpenTelemetry Instrumentations
Merge instructions
Additional notes