Skip to content

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jul 22, 2024

What does this PR do? What is the motivation?

Document Python and Ruby drop in support for the OpenTelemetry Instrumentations

Merge instructions

  • Please merge after reviewing

Additional notes

@mabdinur mabdinur force-pushed the munir/document-drop-in branch from f1f4b1b to b478764 Compare July 22, 2024 17:02
@mabdinur mabdinur changed the title opentelemetry(apm): document python drop in support opentelemetry(apm): document python and ruby drop in support Jul 24, 2024
@mabdinur mabdinur requested a review from zacharycmontoya July 24, 2024 16:57
@mabdinur mabdinur marked this pull request as ready for review July 24, 2024 16:57
@mabdinur mabdinur requested a review from a team as a code owner July 24, 2024 16:57
@mabdinur mabdinur requested a review from brett0000FF July 24, 2024 16:57
@mabdinur mabdinur force-pushed the munir/document-drop-in branch 3 times, most recently from bb9cc53 to 4f51496 Compare July 24, 2024 17:11
@mabdinur mabdinur force-pushed the munir/document-drop-in branch from 3bdb97e to 8c9aa08 Compare July 24, 2024 18:40
@mabdinur mabdinur requested a review from mtoffl01 July 24, 2024 18:44
Copy link
Contributor

@mtoffl01 mtoffl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you change "Using operations only supported by
OpenTelemetry SDK are not supported (ex: SpanProcessors, OTLP Trace Exporters)."
to something like,
"Items specific to the Opentelemetry SDK (ex: SpanProcessors, OTLP Trace Exporters) are not supported."

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! 🙏 I left a few suggestions for you to consider. Please let me know if my comment on the Prerequisites section is unclear. I was unable to suggest changes since my comment spanned several lines that weren't changed.

@DataDog DataDog deleted a comment from github-actions bot Jul 26, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@mabdinur mabdinur force-pushed the munir/document-drop-in branch from 8c582c7 to 4000bcd Compare July 26, 2024 14:53
mabdinur and others added 2 commits July 26, 2024 10:54
fix name

ACCESSINT-23 Mark team and user based access supported for with GRACE for synthetic tests (#24298)

DOCS-8523 Add Multisource Querying Documentation (#24312)

* Move Data Collected

* DOCS-8523

Adds a child doc page for Multisource Querying and accompanying screenshots.

* Add Table Legend

* Word Nit

* This Too

* Formatting Nit

* Doc Review

Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com>

* One More

---------

Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com>

[CLOUDCRAFT-849] Update "Enable SSO" document (#24284)

* Add information about Datadog SSO

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Remove Enterprise requirement for SAML SSO

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Clarify that support can enable the feature

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Match the style guide more closely

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Update image description

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Update Enterprise notice on all documents

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Apply suggestions made by @maycmlee

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Apply one more suggestion by @maycmlee

Signed-off-by: James Pond <james.pond@datadoghq.com>

---------

Signed-off-by: James Pond <james.pond@datadoghq.com>

DOCS-8258 Pipeline Execution Time Update (#24007)

* DOCS-8258

Add a screenshot of a pipeline trace for the pipeline execution time terminology.

* Add Diagram

Update content/en/opentelemetry/interoperability/instrumentation_libraries.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

fix typos

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

clean up

Apply suggestions from code review

Apply suggestions from code review

Apply suggestions from code review

Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>

Apply suggestions from code review

Apply suggestions from code review
@mabdinur mabdinur force-pushed the munir/document-drop-in branch from 4000bcd to a26cb13 Compare July 26, 2024 14:56
@mabdinur mabdinur force-pushed the munir/document-drop-in branch from a26cb13 to 328faaa Compare July 26, 2024 16:30
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@brett0000FF
Copy link
Contributor

@mabdinur - Are we good to go ahead and merge this now? Thanks!

@brett0000FF brett0000FF merged commit 6c2e880 into master Jul 29, 2024
16 checks passed
@brett0000FF brett0000FF deleted the munir/document-drop-in branch July 29, 2024 19:32
rtrieu pushed a commit that referenced this pull request Sep 3, 2024
* opentelemetry(apm): document python drop in support

* document python and ruby support

* more clean ups

* --amend

fix name

ACCESSINT-23 Mark team and user based access supported for with GRACE for synthetic tests (#24298)

DOCS-8523 Add Multisource Querying Documentation (#24312)

* Move Data Collected

* DOCS-8523

Adds a child doc page for Multisource Querying and accompanying screenshots.

* Add Table Legend

* Word Nit

* This Too

* Formatting Nit

* Doc Review

Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com>

* One More

---------

Co-authored-by: Jen Gilbert <jen.gilbert@datadoghq.com>

[CLOUDCRAFT-849] Update "Enable SSO" document (#24284)

* Add information about Datadog SSO

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Remove Enterprise requirement for SAML SSO

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Clarify that support can enable the feature

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Match the style guide more closely

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Update image description

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Update Enterprise notice on all documents

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Apply suggestions made by @maycmlee

Signed-off-by: James Pond <james.pond@datadoghq.com>

* Apply one more suggestion by @maycmlee

Signed-off-by: James Pond <james.pond@datadoghq.com>

---------

Signed-off-by: James Pond <james.pond@datadoghq.com>

DOCS-8258 Pipeline Execution Time Update (#24007)

* DOCS-8258

Add a screenshot of a pipeline trace for the pipeline execution time terminology.

* Add Diagram

Update content/en/opentelemetry/interoperability/instrumentation_libraries.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

fix typos

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

clean up

Apply suggestions from code review

Apply suggestions from code review

Apply suggestions from code review

Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>

Apply suggestions from code review

Apply suggestions from code review

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants