-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DOCS-8114 asm topic reorg for product focus #24291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DOCS-8114 Reorg of Enabling content to make docs more product-focused
revising Compatibility Requirements topic in each product category so its content is product-specific.
PMs want ASM to be called Datadog Application Security, so I made that edit. Added a little edit for clarity on the How It Works page.
Hi @michaelcretzman I started reviewing this but then realized there is something wrong with the menu, a lot of things are still linking to They look slightly different but there are links to both those pages from different areas, however, the menu doesn't exist for that location: ![]() I "think" you want to get rid of any previous references and links to that old |
@aliciascott I've removed the links to the old Enabling folder. I also had to update a doc to resolve a merge conflict that resulted from a PR checked in while my branch is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to just review this in phases, I got through 40 files and some comments here where some files and links need removed/replaced, let me know when those are fixed then I'll review the rest :) Also be sure to add alias to the front matter of the new page pointing to the old location.
https://datadoghq.atlassian.net/wiki/spaces/docs4docs/pages/2174550131/Moving+Docs+Pages
content/en/security/application_security/code_security/setup/_index.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/code_security/setup/compatibility/nginx.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/code_security/setup/compatibility/php.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/code_security/setup/compatibility/ruby.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/code_security/setup/compatibility/serverless.md
Outdated
Show resolved
Hide resolved
...ecurity/application_security/software_composition_analysis/setup/compatibility/serverless.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/code_security/setup/_index.md
Outdated
Show resolved
Hide resolved
removing serverless topic from SCA as it's not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michaelcretzman this looks great, and it was a huge lift! Feel free to merge when good for you, I don't see any other issues :)
* reorg initial reorg step * saving changes * reorg of ASM docs DOCS-8114 Reorg of Enabling content to make docs more product-focused * fixing broken links * revising Compatibility Requirements revising Compatibility Requirements topic in each product category so its content is product-specific. * minor edit for name changes and clarity PMs want ASM to be called Datadog Application Security, so I made that edit. Added a little edit for clarity on the How It Works page. * updating links * adding PR 21645 This PR was merged while my branch was out: https://github.com/DataDog/documentation/pull/21645/files * fixing links to the old Enabling section * fixing broken links * fixing broken links * incorporating some peer edits * removing serverless topic from SCA removing serverless topic from SCA as it's not used
DOCS-8114
What does this PR do? What is the motivation?
Reorg of the ASM docs so that their onboarding info is more product-focused
Merge instructions
Don't merge until I've reviewed with the PM.