Skip to content

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Aug 13, 2025

What does this PR do? What is the motivation?

  • Adds a few paragraphs and images to go into further details about best practices when creating retention filters for RUM without Limits

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 13, 2025
@rtrieu rtrieu requested review from a team as code owners August 13, 2025 21:26
@github-actions github-actions bot added Images Images are added/removed with this PR Guide Content impacting a guide labels Aug 13, 2025
Copy link
Contributor

github-actions bot commented Aug 13, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Copy link
Contributor

@MaelNamNam MaelNamNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few changes to be more accurate but thanks for putting this together!

Co-authored-by: Maël Lilensten <mael.lilensten@datadoghq.com>
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 26, 2025
@rtrieu rtrieu requested a review from MaelNamNam August 26, 2025 15:05
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few suggestions to consider. 🚀

Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@rtrieu
Copy link
Contributor Author

rtrieu commented Aug 26, 2025

LGTM! Just a few suggestions to consider. 🚀

@brett0000FF Thanks for these finds!

@rtrieu rtrieu merged commit 01fdd93 into master Aug 27, 2025
16 checks passed
@rtrieu rtrieu deleted the rtrieu/docs-11685-update-retention-filters-best-practices branch August 27, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants