Skip to content

Conversation

ryanstrat
Copy link
Contributor

@ryanstrat ryanstrat commented Aug 19, 2025

What does this PR do? What is the motivation?

This PR expands the documentation related to Step Function trace merging and updates the related JSONata strings, which propagate Datadog Context more effectively.

Merge instructions

This is ready to merge once it is approved.

Merge readiness:

  • Ready for merge

@ryanstrat ryanstrat requested review from a team as code owners August 19, 2025 18:58
Copy link
Contributor

github-actions bot commented Aug 19, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@janine-c janine-c self-assigned this Aug 19, 2025
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Ryan! I made some really minor suggestions, but none of them are dealbreakers by any means. Don't hesitate to ping me if you have any questions!

Comment on lines 384 to 388
For services not covered in this guide, you can merge traces by manually propagating [Datadog trace context][3].

**Upstream services to Step Functions**: Include trace context in the Step Function input payload as JSON under the `_datadog` key, which can be located anywhere in the payload.

**Step Functions to Downstream services**: Add Step Function execution context to your task definitions using the patterns shown above. Additional configuration of the downstream service may be required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For services not covered in this guide, you can merge traces by manually propagating [Datadog trace context][3].
**Upstream services to Step Functions**: Include trace context in the Step Function input payload as JSON under the `_datadog` key, which can be located anywhere in the payload.
**Step Functions to Downstream services**: Add Step Function execution context to your task definitions using the patterns shown above. Additional configuration of the downstream service may be required.
For services not covered in this guide, you can merge traces by manually propagating [Datadog trace context][3].
- **Upstream services to Step Functions**: Include trace context in the Step Function input payload as JSON under the `_datadog` key, which can be located anywhere in the payload.
- **Step Functions to downstream services**: Add Step Function execution context to your task definitions using the patterns shown above. Additional configuration of the downstream service may be required.

@janine-c janine-c removed their assignment Aug 19, 2025
Copy link
Contributor

ryanstrat and others added 5 commits August 20, 2025 14:05
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
@ryanstrat ryanstrat requested a review from janine-c August 21, 2025 20:00
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some more minor suggestions 🙂

ryanstrat and others added 3 commits August 21, 2025 16:24
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
@ryanstrat
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 21, 2025

View all feedbacks in Devflow UI.

2025-08-21 20:49:53 UTC ℹ️ Start processing command /merge


2025-08-21 20:50:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-21 21:27:13 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.


2025-08-22 14:03:02 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@ryanstrat ryanstrat merged commit ddea507 into master Aug 22, 2025
20 of 22 checks passed
@ryanstrat ryanstrat deleted the ryan.strat/upstream-sfn-tracing branch August 22, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants