-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[SVLS-7298] Add support for merging upstream traces with Step Function #31180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Ryan! I made some really minor suggestions, but none of them are dealbreakers by any means. Don't hesitate to ping me if you have any questions!
content/en/serverless/step_functions/merge-step-functions-lambda.md
Outdated
Show resolved
Hide resolved
For services not covered in this guide, you can merge traces by manually propagating [Datadog trace context][3]. | ||
|
||
**Upstream services to Step Functions**: Include trace context in the Step Function input payload as JSON under the `_datadog` key, which can be located anywhere in the payload. | ||
|
||
**Step Functions to Downstream services**: Add Step Function execution context to your task definitions using the patterns shown above. Additional configuration of the downstream service may be required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For services not covered in this guide, you can merge traces by manually propagating [Datadog trace context][3]. | |
**Upstream services to Step Functions**: Include trace context in the Step Function input payload as JSON under the `_datadog` key, which can be located anywhere in the payload. | |
**Step Functions to Downstream services**: Add Step Function execution context to your task definitions using the patterns shown above. Additional configuration of the downstream service may be required. | |
For services not covered in this guide, you can merge traces by manually propagating [Datadog trace context][3]. | |
- **Upstream services to Step Functions**: Include trace context in the Step Function input payload as JSON under the `_datadog` key, which can be located anywhere in the payload. | |
- **Step Functions to downstream services**: Add Step Function execution context to your task definitions using the patterns shown above. Additional configuration of the downstream service may be required. |
Preview links (active after the
|
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some more minor suggestions 🙂
content/en/serverless/step_functions/merge-step-functions-lambda.md
Outdated
Show resolved
Hide resolved
content/en/serverless/step_functions/merge-step-functions-lambda.md
Outdated
Show resolved
Hide resolved
content/en/serverless/step_functions/merge-step-functions-lambda.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Added to the queue but the mergequeue is not enabled for now.
This pull request was merged directly. |
What does this PR do? What is the motivation?
This PR expands the documentation related to Step Function trace merging and updates the related JSONata strings, which propagate Datadog Context more effectively.
Merge instructions
This is ready to merge once it is approved.
Merge readiness: