Update ragas_evaluations.md to properly describe what should be passed into DD_LLMOBS_EVALUATORS_SAMPLING_RULES #31313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation to properly describe what is passed into DD_LLMOBS_EVALUATORS_SAMPLING_RULES (objects not list of arrays)
michaelcretzman
approved these changes
Aug 27, 2025
…n sampling The correct env variable for configuring evaluation sampling is DD_LLMOBS_EVALUATOR_SAMPLING_RULES and not DD_LLMOBS_EVALUATORS_SAMPLING_RULES.
|
@michaelcretzman I have updated this PR to include some additional changes. The docs are referencing an incorrect env variable name for configuring sampling of evaluations. incorrect - Thankfully, the notebooks in this repository use the correctly named variable. |
|
Asked Eng Manager to review |
gsvigruha
approved these changes
Aug 28, 2025
brett0000FF
pushed a commit
that referenced
this pull request
Aug 29, 2025
…d into DD_LLMOBS_EVALUATORS_SAMPLING_RULES (#31313) * Update ragas_evaluations.md Update documentation to properly describe what is passed into DD_LLMOBS_EVALUATORS_SAMPLING_RULES (objects not list of arrays) * Update ragas_evaluations.md to use correct env variable for evaluation sampling The correct env variable for configuring evaluation sampling is DD_LLMOBS_EVALUATOR_SAMPLING_RULES and not DD_LLMOBS_EVALUATORS_SAMPLING_RULES. --------- Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Update documentation to properly describe what is passed into DD_LLMOBS_EVALUATORS_SAMPLING_RULES (objects not list of arrays)
Merge instructions
Merge readiness:
Additional notes