Skip to content

Conversation

pcarioufr
Copy link
Contributor

@pcarioufr pcarioufr commented Jan 15, 2020

What does this PR do?

Document new sampling "by attributes" feature. Take this as an opportunity to refurbish the page.

By the way, feature is already released. So feel free to merge as soon as this is approved

Motivation

Preview link

https://docs-staging.datadoghq.com/pcarioufr/exlusionFIlterAttributes/logs/indexes

Additional Notes

@pcarioufr pcarioufr requested a review from a team as a code owner January 15, 2020 20:38
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lefts some comments and wording update suggestions, wdyt ?

pcarioufr and others added 11 commits January 16, 2020 10:56
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Add as many exclusion filters as you need to control your flow. Exclusion filters come with a query, a sampling rule and a active/inactive toggle:

* Default **query** is `*`, meaning all logs flowing in the index (that is to say logs that matched the index filter). Scope down exclusion filter to only a subset of the logs if you need finer control.
* Default **sampling rule** is `Exclude 100% of logs` matching the query. Adapt sampling rate from 0% to 100%, and decide if the sampling rate applies on individual logs, or group of logs defined by the unique values of any attribute. .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, I disagree

pcarioufr and others added 4 commits January 16, 2020 11:04
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
@l0k0ms l0k0ms removed the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 16, 2020
@l0k0ms l0k0ms added the editorial review Waiting on a more in-depth review label Jan 16, 2020
@NBParis
Copy link

NBParis commented Jan 17, 2020

Good with me, we might be missing a capital D on the Datadog in By default, Log Explorer have one unique Log Index, but Datadog also offers multiple indexes if you require:

Enable or disable them in one click on the Pipeline page:
#### Switch off, switch on

You might not need your DEBUG logs... until you actually need them when your platform undergoes an incident, or want to carefully observe the deployment of a critical version of your application. Setup a 100% exclusion filter on the `status:DEBUG`, and toggle it on and off from Datadog UI or through the [API][19] when required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You might not need your DEBUG logs... until you actually need them when your platform undergoes an incident, or want to carefully observe the deployment of a critical version of your application. Setup a 100% exclusion filter on the `status:DEBUG`, and toggle it on and off from Datadog UI or through the [API][19] when required.
You may not need your `DEBUG` logs until you actually need them, like when your platform undergoes an incident or you want to carefully observe the deployment of a critical version of your application. Setup a 100% exclusion filter on the `status:DEBUG`, and toggle it on and off in the Datadog UI or through the [API][19] when required.

pcarioufr and others added 2 commits January 21, 2020 21:14
Co-Authored-By: sarina-dd <57639676+sarina-dd@users.noreply.github.com>
@sarina-dd sarina-dd removed the editorial review Waiting on a more in-depth review label Jan 21, 2020
@sarina-dd sarina-dd merged commit d3b1335 into master Jan 21, 2020
@sarina-dd sarina-dd deleted the pcarioufr/exlusionFIlterAttributes branch January 21, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants