Skip to content

Conversation

xorima
Copy link
Contributor

@xorima xorima commented Feb 12, 2020

What does this PR do?

Adding documentation for granting permissions to pipelines

Motivation

Had to reach out to support for this information, took too long to get an answer

Adding documentation for granting permissions to pipelines
@xorima xorima requested a review from a team as a code owner February 12, 2020 11:35
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plop, just left small changes and updated the links to be relative instead of absolute.

Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
@xorima
Copy link
Contributor Author

xorima commented Feb 12, 2020

resolved @l0k0ms

note should [2]: https://app.datadoghq.com/logs/pipelines also be changed to be relative, and do I need to do this in any other languages or will you handle that internally?

@xorima xorima requested a review from l0k0ms February 12, 2020 13:39
@l0k0ms
Copy link
Contributor

l0k0ms commented Feb 12, 2020

@xorima nop, only docs.datadoghq.com/* links need to be relative, the app link shouldn't.

We are going to perform an audit to the rest of the doc to remove such absolute links

@l0k0ms l0k0ms merged commit 8d756d7 into DataDog:master Feb 12, 2020
@l0k0ms
Copy link
Contributor

l0k0ms commented Feb 12, 2020

Many thanks for this PR :)

@l0k0ms
Copy link
Contributor

l0k0ms commented Feb 12, 2020

pushed the PR to fix all other link ^ #6640

@xorima xorima deleted the Xorima-patch-1 branch February 12, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants