update security info for default logs transport #7621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreVanRoy
reviewed
Jun 3, 2020
change agent transport info to a shorter version which don't specify the behavior of old version
apigirl
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.datadoghq.com/agent/logs/log_transport
https://github.com/DataDog/datadog-agent/blob/master/CHANGELOG.rst#7190--6190
Should I include any notes about how the agent will fall back on TCP if the http check fails, or if the user has configure the agent to us a SOCKS5 proxy server? I figured that would be handled by just linking to that Agent transport doc which has more details about when TCP is used. But am not sure if I should explicitly call it out