Skip to content

Update single template logic #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

Update single template logic #8706

merged 2 commits into from
Oct 1, 2020

Conversation

nsollecito
Copy link
Collaborator

@nsollecito nsollecito commented Oct 1, 2020 •
edited
Loading

What does this PR do?

  • Update and cleanup template logic for the single rule display
  • add missing aws sources to data file

Motivation

Missing Auth0 image:
https://docs.datadoghq.com/security_monitoring/default_rules/auth0-user-authenticating-from-multiple-countries/

Preview

https://docs-staging.datadoghq.com/nsollecito/update-security-imgs/security_monitoring/default_rules/
https://docs-staging.datadoghq.com/nsollecito/update-security-imgs/security_monitoring/default_rules/auth0-user-authenticating-from-multiple-countries/

Additional Notes

Check other rules to make sure images load as expected

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@nsollecito
Update single template logic
4739d0b 
add missing aws sources to data file
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Oct 1, 2020
@nsollecito nsollecito marked this pull request as ready for review October 1, 2020 21:16
@nsollecito nsollecito requested review from a team as code owners October 1, 2020 21:16
ruthnaebeck
ruthnaebeck approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ruthnaebeck ruthnaebeck merged commit a97a713 into master Oct 1, 2020
@ruthnaebeck ruthnaebeck deleted the nsollecito/update-security-imgs branch October 1, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsollecito @ruthnaebeck