[WEB-802] fix ordered list strikethrough issue #8721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgdeutsch
commented
Oct 2, 2020
| version "1.1.1" | ||
| resolved "https://registry.yarnpkg.com/marked/-/marked-1.1.1.tgz#e5d61b69842210d5df57b05856e0c91572703e6a" | ||
| integrity sha512-mJzT8D2yPxoPh7h0UXkB+dBj4FykPJ2OIfxAWeIHrvoHDkFxukV/29QxoFQoPM6RLEwhIFdJpmKBlqVM3s2ZIw== | ||
| marked@^1.2.0: |
There was a problem hiding this comment.
i needed to yarn install here because my build was failing otherwise: https://gitlab.ddbuild.io/DataDog/documentation/-/jobs/40885766
stanleegoodspeed
approved these changes
Oct 2, 2020
ruthnaebeck
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
<ol>list items having a "strikethrough" side effect if the list is nested within a<ul>Motivation
https://datadoghq.atlassian.net/browse/WEB-802
Preview
https://docs-staging.datadoghq.com/brian.deutsch/ordered-list-css-fix/tracing/setup/java/?tab=websphere
Additional Notes
Reviewer checklist