Skip to content

Conversation

zacharycmontoya
Copy link
Contributor

What does this PR do?

Adds a new section in the .NET Core compatibility docs to highlight known runtime issues that affect Datadog automatic instrumentation.

Motivation

We discovered another issue that with an older version of .NET Core 2.0

Preview

https://docs-staging.datadoghq.com/zach.montoya/net-core-2.0.0/tracing/compatibility_requirements/dotnet-core/

Additional Notes

N/A


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@zacharycmontoya zacharycmontoya requested review from jaycdave88 and a team October 30, 2020 18:46
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Oct 30, 2020
Copy link
Contributor

@andrewardito andrewardito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this.

@zacharycmontoya
Copy link
Contributor Author

Sorry for the inactivity on this, I was still working through some feedback from the engineering team. Until I finalize that, I will keep this as a draft and re-request approvals if things change.

@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/net-core-2.0.0 branch from 26ee27d to f3cf336 Compare November 10, 2020 01:23
@zacharycmontoya zacharycmontoya marked this pull request as ready for review November 10, 2020 18:26
@zacharycmontoya zacharycmontoya requested a review from a team as a code owner November 10, 2020 18:26
Copy link
Member

@lucaspimentel lucaspimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@andrewardito andrewardito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apigirl apigirl merged commit 692ddf6 into master Nov 10, 2020
@apigirl apigirl deleted the zach.montoya/net-core-2.0.0 branch November 10, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracing Content changed in the tracing folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants