Update to canonical hostname selection hierarchy #9981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hostnames that start with ip or domu are automatically skipped in favor of other hostnames even if they're set in the datadog.yaml or DD_HOSTNAME environment variable. https://github.com/DataDog/datadog-agent/blob/master/docs/agent/hostname_force_config_as_canonical.md
apigirl
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hostnames that start with ip or domu are automatically skipped in favor of other hostnames even if they're set in the datadog.yaml or DD_HOSTNAME environment variable.
https://github.com/DataDog/datadog-agent/blob/master/docs/agent/hostname_force_config_as_canonical.md
What does this PR do?
Add a small caveat to the logic that the agent uses to decide on a canonical hostname
Motivation
An escalation pointed that the logic was flawed and that names with ip-* was getting passed over even though they were manually set.
Preview
https://docs.datadoghq.com/agent/faq/how-datadog-agent-determines-the-hostname/?tab=agentv6v7#potential-host-names
Reviewer checklist