-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Enable doxygen version to be configured #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable doxygen version to be configured #30
Conversation
Maybe the version number could be made an input variable so the user can choose the version and it could default to a specific version. What do you think? |
@DenverCoder1 - I did think about that, I can modify the PR. give me a second. |
57914cf
to
bba9948
Compare
@DenverCoder1 - don't merge this. Making this a parameter is more fiddly. Leave it with me. |
bba9948
to
bf069f7
Compare
@DenverCoder1 - so I have made the changes to make this a parameter. Note - in my testing, I discovered that this approach only works for versions 1.9.3 and higher. Previously this action was defaulting to 1.9.1. So this might be considered a breaking change. That is your call though. |
Do you know there are significant differences between 1.9.1 and 1.9.6? If for most people, it shouldn't make a difference, it should be fine to make this a breaking change. |
There are no breaking changes according to their changelog. My code works with 1.9.1-1.12.0. I just need a capability they added in 1.9.6. |
@DenverCoder1 - is there anything more you want me to do on this? |
I will test and this should be good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the contribution 🎉
This makes the version of doxygen a paramter and allows the installation of versions that might not be available via
apt-get
.Closes #29