Skip to content

feat: Enable doxygen version to be configured #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

baynezy
Copy link
Contributor

@baynezy baynezy commented Aug 6, 2024

This makes the version of doxygen a paramter and allows the installation of versions that might not be available via apt-get.

Closes #29

@DenverCoder1
Copy link
Owner

Maybe the version number could be made an input variable so the user can choose the version and it could default to a specific version. What do you think?

@baynezy
Copy link
Contributor Author

baynezy commented Aug 6, 2024

@DenverCoder1 - I did think about that, I can modify the PR. give me a second.

@baynezy
Copy link
Contributor Author

baynezy commented Aug 6, 2024

@DenverCoder1 - don't merge this. Making this a parameter is more fiddly. Leave it with me.

@baynezy baynezy force-pushed the feature/specific-version branch from bba9948 to bf069f7 Compare August 6, 2024 13:12
@baynezy
Copy link
Contributor Author

baynezy commented Aug 6, 2024

@DenverCoder1 - so I have made the changes to make this a parameter.

Note - in my testing, I discovered that this approach only works for versions 1.9.3 and higher. Previously this action was defaulting to 1.9.1. So this might be considered a breaking change. That is your call though.

@baynezy baynezy changed the title Force doxygen install to be version 1.9.6 Enable doxygen version to be configured Aug 6, 2024
@DenverCoder1
Copy link
Owner

Do you know there are significant differences between 1.9.1 and 1.9.6? If for most people, it shouldn't make a difference, it should be fine to make this a breaking change.

@baynezy
Copy link
Contributor Author

baynezy commented Aug 7, 2024

There are no breaking changes according to their changelog. My code works with 1.9.1-1.12.0. I just need a capability they added in 1.9.6.

@baynezy
Copy link
Contributor Author

baynezy commented Aug 8, 2024

@DenverCoder1 - is there anything more you want me to do on this?

@DenverCoder1
Copy link
Owner

I will test and this should be good 👍

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Enable doxygen version to be configured feat: Enable doxygen version to be configured Aug 8, 2024
@DenverCoder1 DenverCoder1 merged commit 7cce245 into DenverCoder1:main Aug 8, 2024
@baynezy baynezy deleted the feature/specific-version branch August 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doxygen version is limited to the latest version available via apt-get
2 participants