Skip to content

feat: Added Urdu (Pakistan) Translations #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat: Added Urdu (Pakistan) Translations #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/translations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,15 @@
"Longest Week Streak" => "Найбільша к-сть тижнів",
"Present" => "Наразі",
],
"ur_PK" => [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should preferably be just "ur", unless Urdu (Pakistan) is different enough from Urdu (India) that it needs to be translated separately.

Suggested change
"ur_PK" => [
"ur" => [

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. So there are a few structural differences between the two versions and there are some words as well that are either spelt differently or are totally different. I think it would be better that they are kept different, but later on if someone comes in to translate for "ur" I think they will be able to alias this if they believe ur_PK works for that version too.

"rtl" => true,
"Total Contributions" => "کل حصہ داری",
"Current Streak" => "موجودہ تسلسل",
"Longest Streak" => "طویل ترین تسلسل",
"Week Streak" => "ہفتہ وار تسلسل",
"Longest Week Streak" => "طویل ترین ہفتہ وار تسلسل",
"Present" => "حاظر",
],
"vi" => [
"Total Contributions" => "Tổng số đóng góp",
"Current Streak" => "Chuỗi đóng góp\nhiện tại",
Expand Down