State pattern is maintainable #285
Conversation
state pattern change readme.rst
|
|
||
| class ContextOrder extends StateOrder | ||
| { | ||
| public function getState():StateOrder |
There was a problem hiding this comment.
PHP 7 sintax should go to php7 branch #169 (comment). Master branch still PHP 5.6 compatible
There was a problem hiding this comment.
What you say about https://github.com/domnikl/DesignPatternsPHP/blob/master/Structural/Adapter/Book.php#L22? It's master.
There was a problem hiding this comment.
My bad, didn't know that php7 branch was merged on master #235
Behavioral/State/CreateOrder.php
Outdated
| return $this->details['status']; | ||
| $order = new ShippingOrder(); | ||
| static::$state = $order; | ||
| //$this->setStatus('shipping'); |
There was a problem hiding this comment.
also $order is superfluous here: static::$state = new ShippingOrder()
| $contextOrder = new ContextOrder(); | ||
| $contextOrder->setState($order); | ||
| $contextOrder->done(); | ||
| $contextOrder->done(); |
There was a problem hiding this comment.
why done() is fired twice?
There was a problem hiding this comment.
It's show, that's order from create go to shipping and after to completed. Our states is connected. It's normal behaviour, one order transform from one state to another.
Behavioral/State/CreateOrder.php
Outdated
| return $this->details['status']; | ||
| $order = new ShippingOrder(); | ||
| static::$state = $order; | ||
| //$this->setStatus('shipping'); |
There was a problem hiding this comment.
also $order is superfluous here: static::$state = new ShippingOrder()
|
I did, thanks! |
|
Clear. |
I will refactoring this pattern.