enhance delegation example #322
Conversation
There was a problem hiding this comment.
In general I think the approach is ok. Needs some formatting changes.
@domnikl - would you like to merge?
More/Delegation/JuniorDeveloper.php
Outdated
| @@ -8,4 +8,11 @@ public function writeBadCode(): string | |||
| { | |||
| return 'Some junior developer generated code...'; | |||
| } | |||
| /** | |||
There was a problem hiding this comment.
Since you are changing the file please work on proper formatting. Thanks.
There was a problem hiding this comment.
Sure, tnx. Comments was added just to explain reason for change.
There was a problem hiding this comment.
@carousel - I mean new line before comments of course :)
More/Delegation/TeamLead.php
Outdated
| @@ -21,4 +21,17 @@ public function writeCode(): string | |||
| { | |||
| return $this->junior->writeBadCode(); | |||
| } | |||
| public function writeBadCode(): string | |||
There was a problem hiding this comment.
It needs a space between the methods definitions
| /** | ||
| * @test | ||
| */ | ||
| public function teamLeadCanBlameJuniorForBadCode() |
There was a problem hiding this comment.
please use the test in method name convention here instead of using @test: testTeamLeadCanBlameJuniorForBadCode
|
@carousel could you please fix the issues in the PR mentioned by @malukenho and me? Then it is ready to get merged. |
|
sure, working on it |
|
@carousel merged, thx! |
Hi folks;
I have enhanced delegation pattern example by sending $this object as context (TeamLead) to delegate (Junior)
Cheers