Skip to content

Fix mismatched string references for russian l10n. Translate NULL-object examples #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

smithalex
Copy link
Contributor

Some translated strings have typos in their messageId and so the translation doesn't get applied

See occasional lines in english:

This fix should improve the ru localization a little bit. I haven't checked other languages for the same typos

Also, added a translation for NullObject examples https://designpatternsphp.readthedocs.io/ru/latest/Behavioral/NullObject/README.html

Copy link
Contributor

@BorislavSabev BorislavSabev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission

@BorislavSabev BorislavSabev merged commit 16cde74 into DesignPatternsPHP:main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants