Fullscreen Overlay Navigation #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completed making the idea of full screen navbar
Abirpal202049
approved these changes
Jan 7, 2022
thepranaygupta
requested changes
Jan 7, 2022
Comment on lines
9
to
20
| body { | ||
| font-family: 'Playfair Display', serif; | ||
| background: #fdfdea; | ||
| transition: all 2s ease; | ||
| } | ||
| h1 { | ||
| font-size: 4rem; | ||
| font-weight: 400; | ||
| } | ||
| h3 { | ||
| font-size: 1.5em; | ||
| } |
There was a problem hiding this comment.
don't add styling directly to HTML tags, use classes instead
There was a problem hiding this comment.
@thepranaygupta did the changes 👍.
Applied css to classes of tags instead of applying direct to tag names
Abirpal202049
approved these changes
Jan 8, 2022
nandini7637
requested changes
Jan 11, 2022
bhaveyx
approved these changes
Jan 11, 2022
Ovenoboyo
approved these changes
Jan 12, 2022
thepranaygupta
approved these changes
Jan 12, 2022
|
@nandini7637 done 👍 ! added class to body |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed making the idea of full screen navbar
Here is the preview
Fullscreen Overlay Navigation
Tech Stack Used
Preview