Skip to content

Refactored Currency Script project folder structure #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sue-lim
Copy link
Contributor

@sue-lim sue-lim commented May 29, 2025

Refactored Currency Script project folder into modular structure

[FEATURE] Currency Script | Refactor monolithic script into modules #429

Summary

Refactored Currency Script project folder into modular structure including source / tests directories

Description

The changes are as follows:

  • New Source Folder
    -- Relocated currency.py and renamed to currencies.py
    -- Relocated currency_calculator and renames to converter.py
    -- Added api_handler.py
  • New Test Folder
    -- Added test_api_handler.py
    -- Added test_currencies.py
    -- Added test_converter.py
  • Added README
  • Added setup.py
  • Added requirements.txt

Checks

in the repository

  • Made no changes that degrades the functioning of the repository
  • Gave each commit a better title (unlike updated README.md)

in the PR

  • Followed the format of the pull_request_template
  • Made the Pull Request in a small level (for the creator's wellfare)
  • Tested the changes you made

Thank You,
Sue

@sue-lim
Copy link
Contributor Author

sue-lim commented May 30, 2025

@DhanushNehru - please kindly approve PR.

@DhanushNehru DhanushNehru merged commit 08d29b9 into DhanushNehru:master May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants