Add ShowObjects statement #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can merge for now.
Snowflake spec https://docs.snowflake.com/en/sql-reference/sql/show-objects |
eadgbear
previously approved these changes
Feb 3, 2025
osipovartem
previously approved these changes
Feb 3, 2025
Vedin
requested changes
Feb 3, 2025
There was a problem hiding this comment.
In general, I'm fine with this approach. However, I think we can move parse_show_objects to parser/mod.rs itself. Even if it's really limited to Snowflake for now I think it can be found in other databases in the future. At least, Materialize supports SHOW OBJECTS statement.
We can try upstreaming the current solution as is and we'll see suggestions on external review.
40321ce
Vedin
reviewed
Feb 3, 2025
| @@ -13670,8 +13670,8 @@ impl<'a> Parser<'a> { | |||
| } | |||
| false | |||
| } | |||
|
|
|||
| fn parse_show_stmt_options(&mut self) -> Result<ShowStatementOptions, ParserError> { | |||
|
|
|||
There was a problem hiding this comment.
They had the space before me. All their functions actually have spaces before them for some reason :)
Vedin
approved these changes
Feb 3, 2025
Vedin
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Added ShowObjects statement * Parsing, next tests * Small comment * Tests done according to other SHOW statements * Removed unnecessary comments
Vedin
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Added ShowObjects statement * Parsing, next tests * Small comment * Tests done according to other SHOW statements * Removed unnecessary comments
Vedin
added a commit
that referenced
this pull request
Feb 5, 2025
* Add ShowObjects statement (#2) * Added ShowObjects statement * Parsing, next tests * Small comment * Tests done according to other SHOW statements * Removed unnecessary comments * Fix test in other that object cases. Cargo fmt. --------- Co-authored-by: DanCodedThis <94703934+DanCodedThis@users.noreply.github.com>
Vedin
pushed a commit
that referenced
this pull request
Apr 23, 2025
* Added ShowObjects statement * Parsing, next tests * Small comment * Tests done according to other SHOW statements * Removed unnecessary comments
Vedin
pushed a commit
that referenced
this pull request
Apr 23, 2025
* Added ShowObjects statement * Parsing, next tests * Small comment * Tests done according to other SHOW statements * Removed unnecessary comments
Vedin
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Added ShowObjects statement * Parsing, next tests * Small comment * Tests done according to other SHOW statements * Removed unnecessary comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.