Correção para quando enviar uma localização. #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etro content é do tipo string nas chamadas de findBotByTrigger() em chatbot.controller.
Reviewer's Guide by SourceryThis pull request fixes a type mismatch error that occurs when sending a location. The Sequence diagram for sending a locationsequenceDiagram
participant User
participant WhatsApp
participant getConversationMessage
participant chatbot.controller
User->>WhatsApp: Sends location
WhatsApp->>getConversationMessage: Receives message
activate getConversationMessage
getConversationMessage->>getConversationMessage: Converts degreesLatitude to string
getConversationMessage-->>WhatsApp: Returns message content
deactivate getConversationMessage
WhatsApp->>chatbot.controller: findBotByTrigger(content)
activate chatbot.controller
chatbot.controller-->>WhatsApp: Returns bot response
deactivate chatbot.controller
WhatsApp->>User: Sends bot response
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ricocorreia1 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify the location message is correctly converted to a string.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -10,7 +10,7 @@ const getTypeMessage = (msg: any) => { | |||
| conversation: msg?.message?.conversation, | |||
| extendedTextMessage: msg?.message?.extendedTextMessage?.text, | |||
| contactMessage: msg?.message?.contactMessage?.displayName, | |||
| locationMessage: msg?.message?.locationMessage?.degreesLatitude, | |||
| locationMessage: msg?.message?.locationMessage?.degreesLatitude.toString(), | |||
There was a problem hiding this comment.
suggestion (bug_risk): Potential runtime error if degreesLatitude is undefined.
The change directly invokes toString() on degreesLatitude even though safe chaining is applied up to that property. If degreesLatitude is ever undefined, this call could throw an error. Consider using optional chaining (e.g., msg?.message?.locationMessage?.degreesLatitude?.toString()) or providing a fallback to ensure robustness.
Suggested change
| locationMessage: msg?.message?.locationMessage?.degreesLatitude.toString(), | |
| locationMessage: msg?.message?.locationMessage?.degreesLatitude?.toString(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quando envia uma localização, faz a conversão de degreesLatitude para string, o parametro content é do tipo string nas chamadas de findBotByTrigger() em chatbot.controller e degreesLatitude é do tipo float causando erro de tipagem de dados.
Summary by Sourcery
Bug Fixes: