Skip to content

fix mysql wavoip token #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

fix mysql wavoip token #1433

merged 1 commit into from
May 10, 2025
+26 −0

Conversation

paulocoutinhox
Copy link
Contributor

@paulocoutinhox paulocoutinhox commented May 10, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Add a wavoip token column to the Settings table and create a unique constraint on Chat table

New Features:

  • Add wavoipToken column to Setting table

Enhancements:

  • Create a unique constraint on Chat table for remoteJid and instanceId

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 10, 2025 •
edited
Loading

Reviewer's Guide

This pull request introduces a database migration that adds a wavoipToken column to the Setting table and a unique constraint to the Chat table using a new SQL migration file.

File-Level Changes

Change Details Files
Added wavoipToken column to Setting table and a unique constraint to Chat table.
  • Defined an SQL migration to add a wavoipToken VARCHAR(100) column to the Setting table, ensuring the column is added only if it doesn't already exist.
  • Added a unique constraint unique_remote_instance to the Chat table for the combination of remoteJid and instanceId columns.
 prisma/mysql-migrations/20250510035200_add_wavoip_token_to_settings_table/migration.sql

Possibly linked issues

  • #0: PR adds the missing wavoipToken database column, fixing the startup error.
  • #0: The PR adds the missing wavoipToken column to the MySQL database schema, directly addressing the issue.
  • Docker folder is deleted #1: PR adds the wavoipToken column missing per the issue logs, resolving the instance creation error.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@paulocoutinhox paulocoutinhox mentioned this pull request May 10, 2025
Open
1 task
sourcery-ai[bot]
sourcery-ai bot reviewed May 10, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @paulocoutinhox - I've reviewed your changes - here's some feedback:

  • The PR title and migration file name only mention the wavoipToken addition; consider updating them to reflect that a unique constraint is also added to the Chat table.
  • Consider if the wavoipToken addition and the Chat table unique constraint should be in separate migrations as they appear to address distinct concerns.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DavidsonGomes DavidsonGomes changed the base branch from main to develop May 10, 2025 13:30
@DavidsonGomes DavidsonGomes merged commit e5989f3 into EvolutionAPI:develop May 10, 2025
1 check passed
@paulocoutinhox paulocoutinhox deleted the fix-mysql-wavoip-token branch June 11, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulocoutinhox @DavidsonGomes