Skip to content

feat(channel): enhance pushName logic for messages #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

feat(channel): enhance pushName logic for messages #1457

merged 1 commit into from
May 16, 2025

Conversation

gomessguii
Copy link
Contributor

@gomessguii gomessguii commented May 16, 2025 •
edited by sourcery-ai bot
Loading

  • Updated the pushName selection to differentiate between group and individual messages.
  • Added conditional logic to display the chat name for group messages and the sender's name for individual messages.

Summary by Sourcery

Enhance pushName logic to differentiate between group and individual messages and adjust outgoing message name display

Enhancements:

  • Use group chat name for pushName in group messages and fallback to contact or message name for individual messages
  • Display 'Você' as the lastMessagePushName for messages sent by the current user

@gomessguii
feat(channel): enhance pushName logic for messages
d3ee370 
- Updated the pushName selection to differentiate between group and individual messages.
- Added conditional logic to display the chat name for group messages and the sender's name for individual messages.
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 16, 2025 •
edited
Loading

Reviewer's Guide

Introduces conditional logic in the channel service to select appropriate display names: using the chat’s name for group messages or the contact’s pushName/message pushName for individual chats, and replacing the lastMessagePushName with “Você” for outgoing messages.

File-Level Changes

Change Details Files
Differentiate pushName between group and individual messages
  • Replaced COALESCE with a CASE on remoteJid ending in '@g.us'
  • Use Chat.name for group message names, fallback to Contact.pushName or Message.pushName
  • Retained original logic for individual messages
 src/api/services/channel.service.ts
Override lastMessagePushName for outgoing messages
  • Replaced direct Message.pushName with CASE when fromMe = 'true'
  • Display static “Você” for outgoing messages, fallback to Message.pushName for incoming
 src/api/services/channel.service.ts
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@DavidsonGomes DavidsonGomes merged commit 33c808b into EvolutionAPI:develop May 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomessguii @DavidsonGomes