Skip to content

Fix-chatwoot-import #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Fix-chatwoot-import #1481

merged 1 commit into from
May 21, 2025

Conversation

AlexSzefezuk
Copy link
Contributor

@AlexSzefezuk AlexSzefezuk commented May 21, 2025 •
edited by sourcery-ai bot
Loading

Sugestão de correção para issue:

#1480

Summary by Sourcery

Fix message import to avoid duplicates by scoping retrieval of existing source IDs to the correct conversation

Bug Fixes:

  • Accept an optional conversationId in getExistingSourceIds and adjust the SQL query to filter by conversation_id when provided
  • Pass conversationId from ChatwootService to getExistingSourceIds to prevent duplicate message imports

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 21, 2025 •
edited
Loading

Reviewer's Guide

Refactors Chatwoot import logic to filter existing message source IDs by conversationId, ensuring duplicates are prevented and import behavior is correctly scoped.

File-Level Changes

Change Details Files
Enhanced getExistingSourceIds to accept conversationId and adjust its SQL query
  • Added optional conversationId parameter to the method signature
  • Introduced conditional logic to choose query based on conversationId presence
  • Updated query parameters to include conversationId when provided
 src/api/integrations/chatbot/chatwoot/utils/chatwoot-import-helper.ts
Updated ChatwootService import call to pass conversationId
  • Modified getExistingSourceIds invocation to include conversationId
  • Retained warning path when messages are already saved
 src/api/integrations/chatbot/chatwoot/services/chatwoot.service.ts

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AlexSzefezuk AlexSzefezuk changed the base branch from main to develop May 21, 2025 13:47
@DavidsonGomes DavidsonGomes merged commit fcde1f9 into EvolutionAPI:develop May 21, 2025
@KokeroO
Copy link
Contributor

KokeroO commented May 21, 2025

Esse PR faz muito sentido.

@KokeroO KokeroO mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexSzefezuk @KokeroO @DavidsonGomes