Skip to content

corrige estrutura de if/else e bloco try/catch em chatwoot-import-helper.ts #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

corrige estrutura de if/else e bloco try/catch em chatwoot-import-helper.ts #1493

merged 1 commit into from
May 23, 2025

Conversation

oriondesign2015
Copy link
Contributor

@oriondesign2015 oriondesign2015 commented May 22, 2025 •
edited by sourcery-ai bot
Loading

Esta PR corrige problemas de sintaxe no arquivo chatwoot-import-helper.ts, especificamente:

  • Ajusta a estrutura do bloco if/else no método getExistingSourceIds, evitando erro de compilação do TypeScript.
  • Garante que o bloco catch esteja corretamente posicionado dentro do método, retornando null em caso de erro.
  • Mantém a lógica original do método, apenas corrigindo a sintaxe para permitir a compilação e execução correta do projeto. Essas correções eliminam o erro de build relacionado ao TypeScript e melhoram a robustez do código ao tratar exceções de forma adequada.

Summary by Sourcery

Fix syntax and control flow issues in chatwoot-import-helper.ts to resolve TypeScript build errors and ensure proper method execution

Bug Fixes:

  • Replace improper nested if with an else clause in getExistingSourceIds to correct the conditional structure
  • Add a return statement after cleanup operations to prevent fallthrough and ensure proper method exit

@oriondesign2015
fix: corrige estrutura de if/else e bloco try/catch em chatwoot-impor…
d2263af 
…t-helper.ts

Esta PR corrige problemas de sintaxe no arquivo chatwoot-import-helper.ts, especificamente:
- Ajusta a estrutura do bloco if/else no método getExistingSourceIds, evitando erro de compilação do TypeScript.
- Garante que o bloco catch esteja corretamente posicionado dentro do método, retornando null em caso de erro.
- Mantém a lógica original do método, apenas corrigindo a sintaxe para permitir a compilação e execução correta do projeto.
Essas correções eliminam o erro de build relacionado ao TypeScript e melhoram a robustez do código ao tratar exceções de forma adequada.
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented May 22, 2025 •
edited
Loading

Reviewer's Guide

This PR fixes TypeScript compilation errors in chatwoot-import-helper by correcting the if/else structure in getExistingSourceIds and ensuring all code paths return a value.

File-Level Changes

Change Details Files
Restructure conditional logic in getExistingSourceIds to resolve syntax errors
  • Closed the initial if block before introducing the else
  • Replaced the second if (!conversationId) with else
  • Adjusted brace placement and indentation to align the conditional block
 src/api/integrations/chatbot/chatwoot/utils/chatwoot-import-helper.ts
Add explicit return to maintain consistent method output
  • Inserted return 0; after deleteRepositoryMessagesCache(instance) to cover missing return path
 src/api/integrations/chatbot/chatwoot/utils/chatwoot-import-helper.ts

Possibly linked issues

  • #0: PR fixes syntax in getExistingSourceIds enabling the use of conversationId in the query, which addresses the issue of media not importing.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@oriondesign2015 oriondesign2015 changed the title fix: corrige estrutura de if/else e bloco try/catch em chatwoot-impor… corrige estrutura de if/else e bloco try/catch em chatwoot-import-helper.ts May 22, 2025
neocol83 added a commit to neocol83/evolution-api that referenced this pull request May 22, 2025
@neocol83
corrige estrutura de if/else e bloco try/catch em chatwoot-import-hel…
901d50a 
…per.ts EvolutionAPI#1493
@DavidsonGomes DavidsonGomes merged commit 9cda6a2 into EvolutionAPI:develop May 23, 2025
0 of 2 checks passed
@KokeroO KokeroO mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oriondesign2015 @DavidsonGomes