Skip to content

🐛 fix: Phone number as message ID for Evo AI #ISSUE 28 #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

🐛 fix: Phone number as message ID for Evo AI #ISSUE 28 #1633

merged 1 commit into from
Jun 23, 2025

Conversation

VCalazans
Copy link
Contributor

@VCalazans VCalazans commented Jun 22, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Bug Fixes:

  • Use the phone number extracted from remoteJid as the messageId instead of relying on msg.key.id or a generated UUID

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jun 22, 2025 •
edited
Loading

Reviewer's Guide

Replaces the random UUID fallback for message IDs with the sender’s phone number extracted from the remote JID.

Sequence diagram for messageId assignment in EvoaiService

sequenceDiagram
    participant EvoaiService
    participant RemoteJid
    participant UUID
    EvoaiService->>RemoteJid: Extract phone number (split('@')[0])
    alt Phone number exists
        EvoaiService->>EvoaiService: Assign messageId = phone number
    else Phone number missing
        EvoaiService->>UUID: Generate uuidv4()
        EvoaiService->>EvoaiService: Assign messageId = uuidv4()
    end
Loading

Class diagram for EvoaiService messageId assignment update

classDiagram
    class EvoaiService {
        +sendMessage(msg, remoteJid)
        -callId: string
        -messageId: string
    }
    EvoaiService : messageId = remoteJid.split('@')[0] || uuidv4()
Loading

File-Level Changes

Change Details Files
Use phone number as the messageId instead of a UUID
  • Extract phone number by splitting the JID at '@'
  • Retain UUID as a fallback only if the JID parsing yields no value
 src/api/integrations/chatbot/evoai/services/evoai.service.ts

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@VCalazans VCalazans mentioned this pull request Jun 22, 2025
Open
@DavidsonGomes DavidsonGomes merged commit 873fdcb into EvolutionAPI:develop Jun 23, 2025
1 check passed
VCalazans pushed a commit to VCalazans/evolution-api that referenced this pull request Jun 26, 2025
@DavidsonGomes @VCalazans
Merge pull request EvolutionAPI#1633 from VCalazans/FIX/ISSUE-28
c5121ac 
🐛 fix: Phone number as message ID for Evo AI #ISSUE 28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VCalazans @DavidsonGomes