Fix: prevent applyFormatting from crashing on string or undefined input #1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormatting-e-proteger-entrada Corrige erro em applyFormatting com valores não estruturados Esta correção adiciona verificação de tipo e valor falsy antes de aplicar o processamento de texto. Correção baseada em: EvolutionAPI#1624
Reviewer's GuideIntroduce early input validation in applyFormatting to safely handle string and falsy values, preventing runtime errors when processing simple or undefined message inputs. Class diagram for updated applyFormatting method in TypebotServiceclassDiagram
class TypebotService {
- applyFormatting(element: any): string
}
TypebotService : +applyFormatting(element)
%% The method now returns the element if it's a string, returns '' if falsy, otherwise processes as before.
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @JrStarkmidia - I've reviewed your changes - here's some feedback:
- Consider replacing the
anytype onelementwith a more specific union (e.g.string | RichTextNode | undefined) so TypeScript can help catch invalid inputs at compile time. - You could simplify the guard clause by combining the falsy and string checks into a single condition (
if (!element || typeof element === 'string')).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider replacing the `any` type on `element` with a more specific union (e.g. `string | RichTextNode | undefined`) so TypeScript can help catch invalid inputs at compile time.
- You could simplify the guard clause by combining the falsy and string checks into a single condition (`if (!element || typeof element === 'string')`).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…formatting Refactor applyFormatting type signature
|
Olá! Envio esta correção para evitar erros ao processar respostas do Typebot que são strings simples ou indefinidas. Sugestão aplicada conforme feedback automático do bot Sourcery. |
|
A sua correção não corrige o erro informado, que é |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR corrige o erro
Cannot read properties of undefined (reading 'applyFormatting')que ocorre quando o Typebot envia mensagens simples em formato de string ou valores indefinidos.A função
applyFormattingagora verifica se o valor é uma string ou falsy antes de tentar aplicar formatação. Isso evita que o sistema quebre ao tentar acessar.textou.childrende uma string.Correção útil para integração com Typebot, ChatGPT e outras automações que retornam texto direto.
Summary by Sourcery
Bug Fixes: