Skip to content

improv: Ajustado isEmoji para aceitar todos os emojis. #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

improv: Ajustado isEmoji para aceitar todos os emojis. #1729

merged 2 commits into from
Jul 21, 2025
+23 −6

Conversation

ricaelchiquetti
Copy link

@ricaelchiquetti ricaelchiquetti commented Jul 17, 2025 •
edited by sourcery-ai bot
Loading

Descrição

Este PR melhora a função isEmoji no sendMessage.controller.ts para validar corretamente strings que contêm apenas um emoji. A implementação anterior não deixava ser enviado alguns Emojis.

O que foi feito

  • Substituí a lógica de verificação de emoji por uma implementação mais robusta utilizando a biblioteca emoji-regex.
  • Garanti que a função retorne true apenas se a string for exatamente um emoji.

Summary by Sourcery

Improve emoji validation in sendMessage.controller by using emoji-regex to ensure only single-emoji strings return true

Enhancements:

  • Replace custom emoji regex with emoji-regex library to validate that strings contain exactly one emoji

Build:

  • Add emoji-regex dependency to package.json

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 17, 2025 •
edited
Loading

Reviewer's Guide

Replaces the handcrafted Unicode regex with the emoji-regex library in isEmoji and enforces that only strings composed of exactly one emoji return true.

Class diagram for isEmoji function update in sendMessage.controller.ts

classDiagram
    class SendMessageController {
    }
    class isEmoji {
        +boolean isEmoji(str: string)
    }
    SendMessageController ..> isEmoji : uses
Loading

File-Level Changes

Change Details Files
Refactor isEmoji to use emoji-regex for robust emoji detection
  • Imported emojiRegex from 'emoji-regex'
  • Removed the old manual Unicode-range regex
  • Updated logic to match against emojiRegex() and verify exactly one match equals the input
 src/api/controllers/sendMessage.controller.ts
Add emoji-regex as a project dependency
  • Added 'emoji-regex' to package.json dependencies
  • Updated package-lock.json to include the new dependency
 package.json
package-lock.json
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ricaelchiquetti - I've reviewed your changes - here's some feedback:

  • Consider moving the call to emojiRegex() outside of isEmoji so the regex is only compiled once instead of on every function call.
  • Double-check if you really want isEmoji('') to return true—treating an empty string as a valid emoji might be unintuitive.
Prompt for AI Agents 
Please address the comments from this code review:
## Overall Comments
- Consider moving the call to emojiRegex() outside of isEmoji so the regex is only compiled once instead of on every function call.
- Double-check if you really want isEmoji('') to return true—treating an empty string as a valid emoji might be unintuitive.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ricaelchiquetti ricaelchiquetti changed the base branch from main to develop July 17, 2025 12:40
@DavidsonGomes DavidsonGomes merged commit f59cae7 into EvolutionAPI:develop Jul 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricaelchiquetti @DavidsonGomes