Potential fix for code scanning alert no. 1: Arbitrary file access during archive extraction ("Zip Slip") #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/FRNKUSD/code-scanning-javascript-demo/security/code-scanning/1
To fix the issue, we need to validate
header.linkname
to ensure it does not contain directory traversal elements (..
) or other unsafe characters before using it in a filesystem operation. The best approach is to check if the resolved path remains within the intended directory (cwd
) after combining it withheader.linkname
. This ensures that malicious paths attempting to escape the target directory are blocked.Steps to implement the fix:
header.linkname
before constructingsrcpath
.cwd
directory.Suggested fixes powered by Copilot Autofix. Review carefully before merging.