Update JavaScript tools #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejball
reviewed
Jun 14, 2021
| { | ||
| "printWidth": 120, | ||
| "singleQuote": true, | ||
| "useTabs": true |
There was a problem hiding this comment.
Do we normally use tabs with TypeScript? I have no objection to switching to spaces.
There was a problem hiding this comment.
Yes, tabs are the normal Faithlife style.
ddunkin
commented
Jun 14, 2021
| @@ -17,7 +17,7 @@ export interface IServiceError { | |||
| /** The error message. (For developers, not end users.) */ | |||
| message?: string; | |||
| /** Advanced error details. */ | |||
| details?: any; | |||
| details?: Record<string, unknown>; | |||
There was a problem hiding this comment.
This could be a breaking change. I changed it because eslint's default rules complain about any. The alternative is to ignore that rule, either on this line or project-wide.
There was a problem hiding this comment.
I have no objection to this change.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.