fix: correct Vale file format to use proper JSON array

EdwardAngert · Claude · EdwardAngert · commit a5a3d29cafb3 · 2025-04-23T16:14:46.000-04:00
- Fix 'path is invalid; falling back to all' warning - Use proper JSON array format as specified in Vale action docs - Pass files_json directly to Vale action instead of space-separated list - Add helpful comments explaining the formatting choice 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.github/workflows/docs-unified.yaml b/.github/workflows/docs-unified.yaml
@@ -127,7 +127,7 @@ jobs:
         
       # Vale style checking for documentation - only checks changed files
       # This is the ONLY place Vale is actually run - the action in docs-core is a placeholder
-      # Extract and format changed files for Vale in a way similar to tj-actions/changed-files
+      # Format changed files for Vale
       - name: Extract changed files for Vale
         id: extract-changed-files
         if: steps.docs-core-setup.outputs.needs_vale == 'true' && steps.docs-core-setup.outputs.has_changes == 'true'
@@ -142,20 +142,20 @@ jobs:
             exit 0
           fi
           
-          # Extract files as comma-separated string (Vale action input format)
-          CHANGED_FILES=$(echo "$CHANGED_FILES_JSON" | jq -r 'join(",")')
-          echo "Files to check: $CHANGED_FILES"
-          echo "files_to_check=$CHANGED_FILES" >> $GITHUB_OUTPUT
+          # Vale action accepts the original JSON array format, so we can pass it directly
+          echo "Files to check (JSON format): $CHANGED_FILES_JSON"
+          echo "files_json=$CHANGED_FILES_JSON" >> $GITHUB_OUTPUT
           
-          # Create space-separated output as well (like tj-actions/changed-files)
-          CHANGED_FILES_SPACES=$(echo "$CHANGED_FILES_JSON" | jq -r 'join(" ")')
-          echo "all_changed_files=$CHANGED_FILES_SPACES" >> $GITHUB_OUTPUT
+          # For debugging, also store simpler formats
+          echo "all_files=$(echo "$CHANGED_FILES_JSON" | jq -r 'join(" ")')" >> $GITHUB_OUTPUT
 
+      # Use Vale action to check documentation style
       - name: Run Vale style checks
-        if: steps.docs-core-setup.outputs.needs_vale == 'true' && steps.extract-changed-files.outputs.files_to_check != ''
+        if: steps.docs-core-setup.outputs.needs_vale == 'true' && steps.extract-changed-files.outputs.files_json != ''
         uses: errata-ai/vale-action@v2.1.1
         with:
-          files: ${{ steps.extract-changed-files.outputs.files_to_check }}
+          # According to Vale action docs, it accepts a JSON array format
+          files: ${{ steps.extract-changed-files.outputs.files_json }}
           reporter: github-check
           fail_on_error: false
           vale_flags: "--config=.github/docs/vale/.vale.ini"
