Skip to content

windows: Don't panic if driver not installed #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Apr 10, 2025

Trying it out without running as admin to cause it to fail accessing the driver.

# After
> cargo run --no-default-features --features "windows" -p framework_tool -- --test
Self-Test
  SMBIOS Platform:     Framework13AmdAi300
  Dump EC memory region
[ERROR] Failed to find Windows driver. Error { code: HRESULT(0x80070005), message: "Access is denied." }
[ERROR] Failed to communicate with EC. Reason: "Failed to initialize"
    Failed to read EC memory region
FAILED!!
Error: "Fail"
error: process didn't exit successfully: `target\debug\framework_tool.exe --test` (exit code: 1)

# Before
> cargo run --no-default-features --features "windows" -p framework_tool -- --test
Self-Test
  SMBIOS Platform:     Framework13AmdAi300
  Dump EC memory region
thread 'main' panicked at framework_lib\src\chromium_ec\windows.rs:46:14:
called `Result::unwrap()` on an `Err` value: Error { code: HRESULT(0x80070005), message: "Access is denied." }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\framework_tool.exe --test` (exit code: 101)

Trying it out without running as admin to cause it to fail accessing the
driver.

```
> cargo run --no-default-features --features "windows" -p framework_tool -- --test
Self-Test
  SMBIOS Platform:     Framework13AmdAi300
  Dump EC memory region
[ERROR] Failed to find Windows driver. Error { code: HRESULT(0x80070005), message: "Access is denied." }
[ERROR] Failed to communicate with EC. Reason: "Failed to initialize"
    Failed to read EC memory region
FAILED!!
Error: "Fail"
error: process didn't exit successfully: `target\debug\framework_tool.exe --test` (exit code: 1)

> cargo run --no-default-features --features "windows" -p framework_tool -- --test
Self-Test
  SMBIOS Platform:     Framework13AmdAi300
  Dump EC memory region
thread 'main' panicked at framework_lib\src\chromium_ec\windows.rs:46:14:
called `Result::unwrap()` on an `Err` value: Error { code: HRESULT(0x80070005), message: "Access is denied." }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\framework_tool.exe --test` (exit code: 101)
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg JohnAZoidberg merged commit 6824174 into main Apr 10, 2025
6 checks passed
@JohnAZoidberg JohnAZoidberg deleted the win-no-panic branch April 10, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant