Simplify features and detect based on OS #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately no progress on rust-lang/cargo#1197. |
8ebe3ea to
19260ef
Compare
Now we can build on Windows just with `cargo build`! Signed-off-by: Daniel Schaefer <dhs@frame.work>
19260ef to
db46c4b
Compare
|
TODO:
|
Linking doesn't fail anymore for UEFI builds. Signed-off-by: Daniel Schaefer <dhs@frame.work>
There's no need for it, the only no_std environment is UEFI and it's unlikely there'll be another one. Maybe we could rename uefi to no_std in the future, but right now it makes no sense to duplicate it. Signed-off-by: Daniel Schaefer <dhs@frame.work>
9a59034 to
f73981d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can build on Windows and FreeBSD, in addition to previously just Linux: with
cargo buildonly!