Skip to content

Allow flashing EC RW region #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Allow flashing EC RW region #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions framework_lib/src/commandline/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,19 +570,14 @@ fn flash_ec(ec: &CrosEc, ec_bin_path: &str, flash_type: EcFlashType) {
let data = crate::uefi::fs::shell_read_file(ec_bin_path);
#[cfg(not(feature = "uefi"))]
let data: Option<Vec<u8>> = {
let _data = match fs::read(ec_bin_path) {
match fs::read(ec_bin_path) {
Ok(data) => Some(data),
// TODO: Perhaps a more user-friendly error
Err(e) => {
println!("Error {:?}", e);
None
}
};

// EC communication from OS is not stable enough yet,
// it can't be trusted to reliably flash the EC without risk of damage.
println!("Sorry, flashing EC from the OS is not supported yet.");
None
}
};

if let Some(data) = data {
Expand Down
Loading