framework12: Support reading touchpad version #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohnAZoidberg
commented
Apr 2, 2025
•
Must already be on firmware 0E06 or higher. ``` > framework_tool --versions [...] Touchpad IC Type: 0239 Firmware Version: v0E06 ``` Signed-off-by: Daniel Schaefer <dhs@frame.work>
On Windows you can read it using HidD_GetAttributes. The Linux kernel does not expose this. Signed-off-by: Daniel Schaefer <dhs@frame.work>
db8f299 to
7094cad
Compare
fe7cb12 to
6e1d411
Compare
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
commented
Apr 12, 2025
| @@ -28,6 +37,7 @@ pub fn print_touchpad_fw_ver() -> Result<(), HidError> { | |||
| let vid = dev_info.vendor_id(); | |||
| let pid = dev_info.product_id(); | |||
| let usage_page = dev_info.usage_page(); | |||
| let hid_ver = dev_info.release_number(); | |||
There was a problem hiding this comment.
@aokblast could you please check if this value is populated with your changes?
The kernel and hidapi on Linux don't expose that, except for USB. But windows does.
I checked that the FreeBSD kernel does expose it, could you please make sure your hidapi changes do as well?
You can run with -vvv verbose logging and it'll be printed.
There was a problem hiding this comment.
For reference, we checked that it is populated on FreebBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.