Do not activate the sfACPUCache if not supported #175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deny to create an "inactive" sfAPCCache cache, when the apcu extension is not supported, instead of creating the object that does not work as expected. As for php7 the apcu extension requries the apcu-bc extension for backward compatibility reasons
alquerci
reviewed
Jul 21, 2018
alquerci
suggested changes
Nov 10, 2018
| // apcu used in php 5.x. The "apcu-bc" extension to be enabled to provide backward compatibility. | ||
| if (!function_exists('apc_store') || !ini_get('apc.enabled')) | ||
| { | ||
| throw new sfConfigurationException('sfAPCCache class needs the "apc" extension and the "apc_store" function to be enabled.'); |
There was a problem hiding this comment.
Throwing an exception here is a BC breaks. Then to provide a BC layer I propose to introduce an option for that.
|
|
||
| $this->enabled = function_exists('apc_store') && ini_get('apc.enabled'); |
There was a problem hiding this comment.
What do you think to take the opportunity to fix the detection whether it is enabled?
|
Closing in favor of: https://github.com/FriendsOfSymfony1/CacheLegacyBridge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deny to create an "inactive" sfAPCCache cache, when the apcu extension is not supported, instead
of creating the object that does not work as expected.
As for php7 the apcu extension requries the apcu-bc extension for backward compatibility reasons