Add reset functionality to examples #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scn) caused issues when the tween was run again To Replicate the Bug: Navigate in Lesson 5 to the example in which the turtle draws a square of variable(set by a "Size" slider) length. Click the button labelled "draw_square()". While the animation is running, change the "Size" slider to a new number and click the button labelled "Reset". Click the "draw_square()" button again and let the animation complete. You should be able to spot the bug in the form of the turtle making unexpected and unwanted movements.
|
Thanks much for the contribution. Please excuse the time it took to review this but I've been working seven days a week until two days ago to finish our latest course in time. I unfortunately didn´t have much time for other projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
Related issue:
#445
Does this PR introduce a breaking change?
I do not expect it to and I wasn't able to find any breaks during testing.
Notes specific to lessons
Lesson 5 - Turtle Examples
There is a difference between the start position and the reset position of the turtle e.g. in the first example:
Start Position:
Reset Position:
I argue that the start position should be replaced by the reset position because when the code is run, the actual animation starts after "shifting" the turtle to the reset position. While there are very little chances of this "shifting" being confused with an actual command, it does look awkward especially in places where the difference between the reset position and the start position is small but noticeable(e.g. turtle square example with the size set to 40).
Lesson 15
No resetting functionality has been added for
and
Lesson 21
No resetting functionality has been added for the following example since it does not modify the state of the example in any way
Lesson 24 - Inventory Examples
No resetting functionality has been added for any inventory example since they do not modify the state of the example in any way e.g.
