Skip to content

use secure link for faye in readme to get 5 more points in pub.dev #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

balvinderz
Copy link
Contributor

@balvinderz balvinderz commented Nov 1, 2021

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Right now the faye link uses http which is unsecure , so pub.dev has deducted 5 points for this. I have changed the http link to https.
There is only readme change so i have not added any tests.

@sachaarbonel sachaarbonel changed the base branch from master to support-extraData-null-value November 1, 2021 18:05
@balvinderz
Copy link
Contributor Author

i have merged the support-extraData-null-value branch in this branch.

Copy link
Member

@sachaarbonel sachaarbonel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @balvinderz thanks for contributing to this repo

LGTM

@sachaarbonel sachaarbonel merged commit c5c412c into GetStream:support-extraData-null-value Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants