Skip to content

FlatFeedCore tweaks #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

GroovinChip
Copy link
Contributor

This PR makes some minor tweaks to FlatFeedCore

  • Allows the passing through of ScrollPhysics to FlatFeedCore. This allows for more flexible options in more complex layouts.
  • Use ListView.separated

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@GroovinChip GroovinChip changed the base branch from master to support-extraData-null-value November 3, 2021 18:49
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #171 (a306e5b) into support-extraData-null-value (e4947b3) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           support-extraData-null-value     #171      +/-   ##
================================================================
- Coverage                         76.38%   76.32%   -0.06%     
================================================================
  Files                                87       87              
  Lines                              2638     2640       +2     
================================================================
  Hits                               2015     2015              
- Misses                              623      625       +2     
Impacted Files Coverage Δ
...ream_feed_flutter_core/lib/src/flat_feed_core.dart 64.86% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4947b3...a306e5b. Read the comment docs.

@sachaarbonel sachaarbonel merged commit d4bee8b into support-extraData-null-value Nov 3, 2021
@sachaarbonel sachaarbonel deleted the sample_general_updates2 branch November 3, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants