Skip to content

Upload core #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 106 commits into from
Dec 22, 2021
Merged

Upload core #175

merged 106 commits into from
Dec 22, 2021

Conversation

sachaarbonel
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #175 (b8a7640) into master (3f6b93d) will decrease coverage by 1.15%.
The diff coverage is 65.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   76.41%   75.25%   -1.16%     
==========================================
  Files          88       93       +5     
  Lines        2658     2987     +329     
==========================================
+ Hits         2031     2248     +217     
- Misses        627      739     +112
Impacted Files Coverage Δ
...m_feed/lib/src/client/stream_feed_client_impl.dart 91.40% <ø> (+0.06%) ⬆️
...utter_core/lib/src/bloc/activities_controller.dart 73.07% <ø> (ø)
...lutter_core/lib/src/bloc/reactions_controller.dart 88.46% <ø> (ø)
...feed_flutter_core/lib/src/reactions_list_core.dart 75.86% <ø> (ø)
...ream_feed_flutter_core/lib/src/upload/widgets.dart 57.05% <57.05%> (ø)
...am_feed_flutter_core/lib/src/upload_list_core.dart 60.86% <60.86%> (ø)
...ckages/stream_feed_flutter_core/lib/src/media.dart 66.66% <66.66%> (ø)
...flutter_core/lib/src/upload/upload_controller.dart 69.23% <69.23%> (ø)
...ream_feed_flutter_core/lib/src/bloc/feed_bloc.dart 83.66% <78.12%> (ø)
...tream_feed_flutter_core/lib/src/upload/states.dart 92.00% <92.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6b93d...b8a7640. Read the comment docs.

sachaarbonel and others added 10 commits December 8, 2021 08:55
@sachaarbonel @HayesGordon
Update packages/stream_feed_flutter_core/lib/src/bloc/feed_bloc.dart
6b9a0b3 
Co-authored-by: Gordon <pggordonhayes@gmail.com>
@sachaarbonel @HayesGordon
Update packages/stream_feed_flutter_core/lib/src/media.dart
4fd71fb 
Co-authored-by: Gordon <pggordonhayes@gmail.com>
@sachaarbonel @HayesGordon
Update packages/stream_feed_flutter_core/lib/src/upload_core.dart
83e16c6 
Co-authored-by: Gordon <pggordonhayes@gmail.com>
@sachaarbonel @HayesGordon
Update packages/stream_feed_flutter_core/lib/src/media.dart
0d6ccaf 
Co-authored-by: Gordon <pggordonhayes@gmail.com>
@sachaarbonel
docs + expose more methods to the bloc
b797d07
@sachaarbonel
remove commented code
ea070da
@HayesGordon
wip: uploads refactor
d8545e4
@HayesGordon
refactor: UploadCore and FeedBloc controllers
f0aad1a
@sachaarbonel
Merge branch 'upload-core' into refactor/upload-core
89a6934
@HayesGordon
Merge pull request #182 from GetStream/refactor/upload-core
20210e5 
wip: uploads refactor
@sachaarbonel sachaarbonel mentioned this pull request Dec 20, 2021
Closed
@sachaarbonel sachaarbonel merged commit d3b87a6 into master Dec 22, 2021
@sachaarbonel sachaarbonel deleted the upload-core branch December 22, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HayesGordon HayesGordon HayesGordon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachaarbonel @HayesGordon