Skip to content

Remove Token From Constructor #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 12, 2022
Merged

Remove Token From Constructor #185

merged 14 commits into from
Jan 12, 2022

Conversation

sachaarbonel
Copy link
Member

No description provided.

@sachaarbonel sachaarbonel changed the title remove redudant media type Remove Token From Constructor Jan 11, 2022
@sachaarbonel sachaarbonel marked this pull request as ready for review January 11, 2022 15:28
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #185 (49a2133) into master (c68f16f) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   79.49%   79.49%   -0.01%     
==========================================
  Files         138      139       +1     
  Lines        4589     4608      +19     
==========================================
+ Hits         3648     3663      +15     
- Misses        941      945       +4
Impacted Files Coverage Δ
...stream_feed/lib/src/client/stream_feed_client.dart 100.00% <ø> (ø)
...eed/lib/src/core/error/stream_feeds_dio_error.dart 0.00% <0.00%> (ø)
...eam_feed/lib/src/core/http/stream_http_client.dart 71.21% <0.00%> (ø)
...m_feed/lib/src/client/stream_feed_client_impl.dart 93.79% <88.00%> (-0.74%) ⬇️
...am_feed/lib/src/core/error/stream_feeds_error.dart 65.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8ab8c...49a2133. Read the comment docs.

HayesGordon
HayesGordon reviewed Jan 12, 2022
View reviewed changes
HayesGordon
HayesGordon reviewed Jan 12, 2022
View reviewed changes
HayesGordon
HayesGordon reviewed Jan 12, 2022
View reviewed changes
HayesGordon
HayesGordon approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some commented code and other nitpicks that can be done.

@sachaarbonel sachaarbonel merged commit 394506e into master Jan 12, 2022
@sachaarbonel sachaarbonel deleted the remove-token-from-constructor branch January 12, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HayesGordon HayesGordon HayesGordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachaarbonel @HayesGordon